mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934.
Date Sat, 02 Sep 2017 02:35:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62050/#review184408
-----------------------------------------------------------




3rdparty/libprocess/src/tests/ssl_tests.cpp
Lines 932 (patched)
<https://reviews.apache.org/r/62050/#comment260596>

    Although we can reproduce this many times, this is still racy and might potentially be
flaky in another environment. Is it possible to use SSL API to ensure that the client first
reads a portion of the data, then we close the write end, then continue reading the remaining
of the data. Not sure how much work this would take and if it is worth the cost, so I'll just
leave a comment but not open an issue.


- Chun-Hung Hsiao


On Sept. 2, 2017, 12:38 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62050/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2017, 12:38 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Bugs: MESOS-7934
>     https://issues.apache.org/jira/browse/MESOS-7934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 6affda8e07d76d925a87f08b297bb6ebb4e3257f

> 
> 
> Diff: https://reviews.apache.org/r/62050/diff/1/
> 
> 
> Testing
> -------
> 
> ran in repetition
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message