mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.
Date Fri, 01 Sep 2017 06:27:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61991/#review184338
-----------------------------------------------------------


Fix it, then Ship it!




LGTM


src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp
Lines 360 (patched)
<https://reviews.apache.org/r/61991/#comment260474>

    s/connecting/invoking
    s/scheduler/connected callback



src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp
Lines 419 (patched)
<https://reviews.apache.org/r/61991/#comment260475>

    How about:
    
    "Disconnected with the Mesos master; invoking the disconnected callback" to be consistent
with the registered logging message?


- Anand Mazumdar


On Aug. 31, 2017, 7:09 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61991/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2017, 7:09 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Till Toenshoff, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411

> 
> 
> Diff: https://reviews.apache.org/r/61991/diff/2/
> 
> 
> Testing
> -------
> 
> None: Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message