From reviews-return-65435-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 30 15:21:35 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 46E601A7D5 for ; Wed, 30 Aug 2017 15:21:35 +0000 (UTC) Received: (qmail 87353 invoked by uid 500); 30 Aug 2017 15:21:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 87330 invoked by uid 500); 30 Aug 2017 15:21:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86949 invoked by uid 99); 30 Aug 2017 15:21:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2017 15:21:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 830A51A0404; Wed, 30 Aug 2017 15:21:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id h1mvuD-yEJzb; Wed, 30 Aug 2017 15:21:26 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7DD995FCE2; Wed, 30 Aug 2017 15:21:25 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9CA62E0044; Wed, 30 Aug 2017 15:21:24 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 19B58C415B9; Wed, 30 Aug 2017 15:21:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8063600453855040801==" MIME-Version: 1.0 Subject: Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating. From: Jie Yu To: Jie Yu , Benjamin Mahler , Gilbert Song Cc: Benjamin Hindman , mesos Date: Wed, 30 Aug 2017 15:21:22 -0000 Message-ID: <20170830152122.20101.79254@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61987/ X-Sender: Jie Yu References: <20170830063047.20100.79540@reviews-vm2.apache.org> In-Reply-To: <20170830063047.20100.79540@reviews-vm2.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============8063600453855040801== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184154 ----------------------------------------------------------- 3rdparty/libprocess/include/process/future.hpp Lines 1695-1696 (patched) IIUC, in this example, `undiscardable([]() { ...; })` lambda won't even be called until the future returned by `foo()` is in a terminal state. In that case, if there is a discard on `future`, the `thenf` callback will set `future` to DISCARDED without calling `undiscardable([]() { ...; })`. Sounds like wither the lambda `[]() { ...; }` has `undiscardable` or not doesn't matter? - Jie Yu On Aug. 30, 2017, 6:30 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61987/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 6:30 a.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-7926 > https://issues.apache.org/jira/browse/MESOS-7926 > > > Repository: mesos > > > Description > ------- > > This can be useful in circumstances where you don't want some > asynchronous operation to be canceled. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp 2f5f0a20b5a39b04fd684b1cb44b6a33b647bbef > 3rdparty/libprocess/src/tests/future_tests.cpp 0c8725b9a5e64aaac6e3979e450a11e84f9bd45e > > > Diff: https://reviews.apache.org/r/61987/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > > --===============8063600453855040801==--