From reviews-return-65348-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 28 18:24:51 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0BE4B1AB4A for ; Mon, 28 Aug 2017 18:24:51 +0000 (UTC) Received: (qmail 57268 invoked by uid 500); 28 Aug 2017 18:24:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57235 invoked by uid 500); 28 Aug 2017 18:24:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57219 invoked by uid 99); 28 Aug 2017 18:24:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Aug 2017 18:24:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5FB39CA960; Mon, 28 Aug 2017 18:24:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id HjxXU1eVMwiw; Mon, 28 Aug 2017 18:24:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A302660D9A; Mon, 28 Aug 2017 18:24:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C5682E0012; Mon, 28 Aug 2017 18:24:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E9C86C40916; Mon, 28 Aug 2017 18:24:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0946111849737862857==" MIME-Version: 1.0 Subject: Re: Review Request 58048: Added id to Resource.DiskInfo. From: Jie Yu To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , mesos Date: Mon, 28 Aug 2017 18:24:43 -0000 Message-ID: <20170828182443.20148.5425@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58048/ X-Sender: Jie Yu References: <20170519211634.19609.13422@reviews-vm2.apache.org> In-Reply-To: <20170519211634.19609.13422@reviews-vm2.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============0946111849737862857== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review183960 ----------------------------------------------------------- src/common/resources.cpp Line 187 (original), 187 (patched) We also need to update `addable` and `subtractable` similar to what we did for persistent volumes. Depending on the "disk" source type, the semantics is different: 1. RAW w/ id: - Cannot be split into smaller pieces - Cannot be merged even if they are equal 2. RAW w/o id: - Can be split into smaller pieces - Can be merged if RAW parts equal 3. PATH w/ id: - Can be split into smaller pieces - Can be merged if PATH parts equal 4. PATH w/o id: - Same as PATH w/ id 5. MOUNT w/ id: - Cannot be split into smaller pieces - Cannot be merged even if they are equal 6. MOUNT w/o id: - Same as MOUNT w/ id - Jie Yu On May 19, 2017, 9:16 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58048/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 9:16 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > Ids will allow to create distinguishable resources, e.g., of RAW or > BLOCK type. > > > Diffs > ----- > > include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154 > include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3 > src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c > src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4 > src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3 > src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d > > > Diff: https://reviews.apache.org/r/58048/diff/4/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > > --===============0946111849737862857==--