From reviews-return-65052-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 18 23:11:11 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 63D7B1A7A2 for ; Fri, 18 Aug 2017 23:11:11 +0000 (UTC) Received: (qmail 34691 invoked by uid 500); 18 Aug 2017 23:11:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 34459 invoked by uid 500); 18 Aug 2017 23:11:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34419 invoked by uid 99); 18 Aug 2017 23:11:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Aug 2017 23:11:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 97CD21A0C51; Fri, 18 Aug 2017 23:11:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.701 X-Spam-Level: **** X-Spam-Status: No, score=4.701 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PlCydQn9p9OO; Fri, 18 Aug 2017 23:11:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 283CB60D02; Fri, 18 Aug 2017 23:11:07 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8BC78E06CC; Fri, 18 Aug 2017 23:11:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 75934C40019; Fri, 18 Aug 2017 23:11:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5390276657598250122==" MIME-Version: 1.0 Subject: Review Request 61763: Added heartbeat interval for V1 Operator API. From: Quinn Leng To: Anand Mazumdar , Greg Mann Cc: Quinn Leng , mesos Date: Fri, 18 Aug 2017 23:11:06 -0000 Message-ID: <20170818231106.44495.24393@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Quinn Leng X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61763/ X-Sender: Quinn Leng Reply-To: Quinn Leng X-ReviewRequest-Repository: mesos --===============5390276657598250122== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61763/ ----------------------------------------------------------- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-7695 https://issues.apache.org/jira/browse/MESOS-7695 Repository: mesos Description ------- Added the heartbeat interval parameter to the SUBSCRIBED event for V1 operator API. Updated the heartbeat test case to check the heartbeat interval. Diffs ----- include/mesos/master/master.proto 7dc5881b843addc2ec59fadb45f31049c7e5a588 include/mesos/v1/master/master.proto db19c5ccc8aca78f901e72f3caf6d46761270bdd src/master/http.cpp b09a9d0ab5fab179d0e400932dce7d3ca958d7a8 src/tests/api_tests.cpp 34480ea6818c904c64cb678562866f0b43dae0d6 Diff: https://reviews.apache.org/r/61763/diff/1/ Testing ------- make check Thanks, Quinn Leng --===============5390276657598250122==--