From reviews-return-64979-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 18 03:55:39 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3900519DAB for ; Fri, 18 Aug 2017 03:55:39 +0000 (UTC) Received: (qmail 37563 invoked by uid 500); 18 Aug 2017 03:55:39 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37456 invoked by uid 500); 18 Aug 2017 03:55:38 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37445 invoked by uid 99); 18 Aug 2017 03:55:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Aug 2017 03:55:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7979F1A0BDF; Fri, 18 Aug 2017 03:55:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id fvcyWznc3hhf; Fri, 18 Aug 2017 03:55:36 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5C78C5F6BF; Fri, 18 Aug 2017 03:55:36 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E7A47E02AA; Fri, 18 Aug 2017 03:55:35 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D02EBC40019; Fri, 18 Aug 2017 03:55:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1879481743917589061==" MIME-Version: 1.0 Subject: Re: Review Request 61704: Added CSI client classes to talk to CSI plugins. From: Jie Yu To: Jie Yu Cc: Chun-Hung Hsiao , mesos Date: Fri, 18 Aug 2017 03:55:35 -0000 Message-ID: <20170818035535.56466.28914@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61704/ X-Sender: Jie Yu References: <20170816230829.51981.47830@reviews-vm2.apache.org> In-Reply-To: <20170816230829.51981.47830@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/csi/csi.cpp X-ReviewBoard-Diff-For: include/mesos/csi/csi.hpp Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============1879481743917589061== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61704/#review183196 ----------------------------------------------------------- include/mesos/csi/csi.hpp Lines 60 (patched) I'd prefer using `CreateVolume` instead of `createVolume`. We do have exceptions for things like this because this is an external interface. Consistency is more important. Ditto on other interfaces. - Jie Yu On Aug. 16, 2017, 11:08 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61704/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 11:08 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: mesos-7491 > https://issues.apache.org/jira/browse/mesos-7491 > > > Repository: mesos > > > Description > ------- > > Added CSI client classes to talk to CSI plugins. > > > Diffs > ----- > > include/mesos/csi/csi.hpp PRE-CREATION > src/csi/csi.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/61704/diff/1/ > > > Testing > ------- > > Tests described in r/61706. > > > Thanks, > > Chun-Hung Hsiao > > --===============1879481743917589061==--