From reviews-return-64944-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Aug 17 20:07:12 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F6541AD50 for ; Thu, 17 Aug 2017 20:07:12 +0000 (UTC) Received: (qmail 29359 invoked by uid 500); 17 Aug 2017 20:07:12 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 29334 invoked by uid 500); 17 Aug 2017 20:07:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 29322 invoked by uid 99); 17 Aug 2017 20:07:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 20:07:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3BA86C04DC; Thu, 17 Aug 2017 20:07:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id YYftfVmXUbVu; Thu, 17 Aug 2017 20:07:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B097A5FBC0; Thu, 17 Aug 2017 20:07:09 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F30A3E0217; Thu, 17 Aug 2017 20:07:08 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 73FB2C40476; Thu, 17 Aug 2017 20:07:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7154646223985376610==" MIME-Version: 1.0 Subject: Re: Review Request 61309: Imported ZooKeeper library. From: Joseph Wu To: Joseph Wu , Andrew Schwartzmeyer , mesos Date: Thu, 17 Aug 2017 20:07:07 -0000 Message-ID: <20170817200707.56474.48458@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61309/ X-Sender: Joseph Wu X-ReviewBoard-ShipIt: 1 References: <20170809005224.27165.57913@reviews-vm2.apache.org> In-Reply-To: <20170809005224.27165.57913@reviews-vm2.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============7154646223985376610== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61309/#review183151 ----------------------------------------------------------- Ship it! Hmm... I will not squash this one into the other library import reviews (more functional differences in this review compared to the other ones). - Joseph Wu On Aug. 8, 2017, 5:52 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61309/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2017, 5:52 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > This commit imports the ZooKeeper C Client as a library, and removes the > discrepancy between Linux and Windows. Both configurations now use > ZooKeeper 3.4.8, with an updated patch to both build with CMake. > > Review: https://reviews.apache.org/r/61309 > > > Diffs > ----- > > 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10 > 3rdparty/cmake/Versions.cmake 9586296420d76bd4493034fd710209008ee03595 > > > Diff: https://reviews.apache.org/r/61309/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============7154646223985376610==--