From reviews-return-64940-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Aug 17 19:13:40 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 568DD1A830 for ; Thu, 17 Aug 2017 19:13:40 +0000 (UTC) Received: (qmail 37723 invoked by uid 500); 17 Aug 2017 19:13:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37687 invoked by uid 500); 17 Aug 2017 19:13:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37676 invoked by uid 99); 17 Aug 2017 19:13:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 19:13:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C0CFE1A1B9C; Thu, 17 Aug 2017 19:13:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mbDstoHtQSq4; Thu, 17 Aug 2017 19:13:37 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C632D5F6C8; Thu, 17 Aug 2017 19:13:36 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 302C8E00A7; Thu, 17 Aug 2017 19:13:36 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 9E3A5C40476; Thu, 17 Aug 2017 19:13:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8721060495256251498==" MIME-Version: 1.0 Subject: Re: Review Request 61300: Imported `protoc` executable. From: Joseph Wu To: Joseph Wu Cc: Andrew Schwartzmeyer , mesos Date: Thu, 17 Aug 2017 19:13:34 -0000 Message-ID: <20170817191334.56474.99266@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61300/ X-Sender: Joseph Wu X-ReviewBoard-ShipIt: 1 References: <20170802005520.55936.84514@reviews-vm2.apache.org> In-Reply-To: <20170802005520.55936.84514@reviews-vm2.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============8721060495256251498== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61300/#review183100 ----------------------------------------------------------- Ship it! May possibly squash into https://reviews.apache.org/r/61291/ before committing. - Joseph Wu On Aug. 1, 2017, 5:55 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61300/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2017, 5:55 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-3576 > https://issues.apache.org/jira/browse/MESOS-3576 > > > Repository: mesos > > > Description > ------- > > This allows `protoc` to be used in `add_custom_command` with an implicit > dependency. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 > > > Diff: https://reviews.apache.org/r/61300/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============8721060495256251498==--