From reviews-return-64924-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Aug 17 04:01:03 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EA3D1A68E for ; Thu, 17 Aug 2017 04:01:03 +0000 (UTC) Received: (qmail 51304 invoked by uid 500); 17 Aug 2017 04:01:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 51267 invoked by uid 500); 17 Aug 2017 04:01:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 51255 invoked by uid 99); 17 Aug 2017 04:01:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 04:01:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 289BCC6362; Thu, 17 Aug 2017 04:01:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.202 X-Spam-Level: **** X-Spam-Status: No, score=4.202 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6N3_7pFmch33; Thu, 17 Aug 2017 04:01:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 18AA75F298; Thu, 17 Aug 2017 04:01:01 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5AC21E0114; Thu, 17 Aug 2017 04:01:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6D114C40495; Thu, 17 Aug 2017 04:00:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8167623222206174431==" MIME-Version: 1.0 Subject: Re: Review Request 61602: Fixed mesos containerizer to support docker image WORKDIR missing. From: Jie Yu To: Jie Yu , Qian Zhang , Kevin Klues Cc: Gilbert Song , mesos Date: Thu, 17 Aug 2017 04:00:58 -0000 Message-ID: <20170817040058.51981.61898@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61602/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20170817033328.51981.34206@reviews-vm2.apache.org> In-Reply-To: <20170817033328.51981.34206@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============8167623222206174431== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61602/#review183097 ----------------------------------------------------------- Ship it! Ship It! - Jie Yu On Aug. 17, 2017, 3:33 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61602/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2017, 3:33 a.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, and Qian Zhang. > > > Bugs: MESOS-7652 > https://issues.apache.org/jira/browse/MESOS-7652 > > > Repository: mesos > > > Description > ------- > > Some docker image may have 'WORKDIR' set in its manifest but that > 'WORKDIR' does not exist in the image rootfs (e.g., the workdir > is removed in the following dockerfile). > > From the reference of dockerfile, "If the WORKDIR doesn’t exist, > it will be created even if it’s not used in any subsequent > Dockerfile instruction". So we should create the working directory > if it does not exist in the image's rootfs. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp 8e662931697a2f20e0ac1e80a2911b96f646b5af > > > Diff: https://reviews.apache.org/r/61602/diff/2/ > > > Testing > ------- > > make > > Manually tested using 'quay.io/spinnaker/front50:master' docker image. > > > Thanks, > > Gilbert Song > > --===============8167623222206174431==--