From reviews-return-64488-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 7 22:12:24 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5521D1A59C for ; Mon, 7 Aug 2017 22:12:24 +0000 (UTC) Received: (qmail 83164 invoked by uid 500); 7 Aug 2017 22:12:24 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 83127 invoked by uid 500); 7 Aug 2017 22:12:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83116 invoked by uid 99); 7 Aug 2017 22:12:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Aug 2017 22:12:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 64762C02AA; Mon, 7 Aug 2017 22:12:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id OIXua7HWZRpy; Mon, 7 Aug 2017 22:12:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C362C5F3CC; Mon, 7 Aug 2017 22:12:17 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1355DE010F; Mon, 7 Aug 2017 22:12:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8A7B3C40044; Mon, 7 Aug 2017 22:12:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8276046652665569736==" MIME-Version: 1.0 Subject: Re: Review Request 60003: Reduced copying in defer, dispatch and Future. From: Mesos Reviewbot Windows To: James Peach , haosdent huang , Michael Park , Benjamin Hindman Cc: Mesos Reviewbot Windows , Dmitry Zhuk , mesos Date: Mon, 07 Aug 2017 22:12:15 -0000 Message-ID: <20170807221215.39374.91411@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60003/ X-Sender: Mesos Reviewbot Windows References: <20170804104011.17965.53397@reviews-vm2.apache.org> In-Reply-To: <20170804104011.17965.53397@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============8276046652665569736== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60003/#review182333 ----------------------------------------------------------- Patch looks great! Reviews applied: [60002, 60003] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On Aug. 4, 2017, 10:40 a.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60003/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2017, 10:40 a.m.) > > > Review request for mesos, Benjamin Hindman, haosdent huang, James Peach, and Michael Park. > > > Bugs: MESOS-7713 > https://issues.apache.org/jira/browse/MESOS-7713 > > > Repository: mesos > > > Description > ------- > > This reduces number of copies made for each parameter in > a piece of code like this: > > ``` > future.then(defer(pid, &SomeProcess::someMethod, param1, param2)); > ``` > > For the objects that do not support move semantics > (e.g., protobuf messages), number of copies is reduced from 8-10 to 6. > If move semantics is supported, then number of copies is reduced from > 6-7 to 1 if parameter is passed with `std::move`, or 2 otherwise. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/defer.hpp 7f3369e723cb244e97930621cbba89cf7873567d > 3rdparty/libprocess/include/process/deferred.hpp e446621be11ac51f5f91c417cc8975e363c2f715 > 3rdparty/libprocess/include/process/dispatch.hpp 3a0793888dc0df5e3ec31b06f47cd920c71e0db9 > 3rdparty/libprocess/include/process/future.hpp cce950509f58022e79bb51a6e72ea1a005b9cb50 > 3rdparty/libprocess/include/process/http.hpp f637999174d92a98208b5fc49a65f9929efb11a0 > 3rdparty/libprocess/src/tests/benchmarks.cpp 245ff7742b1e2c01c42a66d35d8e4f686603244f > > > Diff: https://reviews.apache.org/r/60003/diff/4/ > > > Testing > ------- > > make check > > Number of copies was checked by using defer to subscribe process for Future callbacks, and passing parameters that count number of copies made. > > > Thanks, > > Dmitry Zhuk > > --===============8276046652665569736==--