From reviews-return-64480-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 7 20:58:29 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 920D31A249 for ; Mon, 7 Aug 2017 20:58:29 +0000 (UTC) Received: (qmail 44589 invoked by uid 500); 7 Aug 2017 20:58:29 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 44555 invoked by uid 500); 7 Aug 2017 20:58:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 44544 invoked by uid 99); 7 Aug 2017 20:58:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Aug 2017 20:58:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BB2F7C5BF1; Mon, 7 Aug 2017 20:58:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ARjoTtQtYrGA; Mon, 7 Aug 2017 20:58:23 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C9C1C5FB40; Mon, 7 Aug 2017 20:58:22 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 117E0E0044; Mon, 7 Aug 2017 20:58:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 60A2BC40044; Mon, 7 Aug 2017 20:58:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8661924291148383599==" MIME-Version: 1.0 Subject: Re: Review Request 61361: Replaced `MESOS_3RDPARTY_*` with `CMAKE_CURRENT_*_DIR`. From: Andrew Schwartzmeyer To: Andrew Schwartzmeyer , mesos Date: Mon, 07 Aug 2017 20:58:19 -0000 Message-ID: <20170807205819.44139.25971@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61361/ X-Sender: Andrew Schwartzmeyer References: <20170807200551.44139.97268@reviews-vm2.apache.org> In-Reply-To: <20170807200551.44139.97268@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============8661924291148383599== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61361/ ----------------------------------------------------------- (Updated Aug. 7, 2017, 1:58 p.m.) Review request for mesos. Repository: mesos Description ------- This variable was superfluous, and set as a side effect of `Mesos3rdpartyConfigure.cmake`. Review: https://reviews.apache.org/r/61361 Diffs (updated) ----- 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10 Diff: https://reviews.apache.org/r/61361/diff/3/ Changes: https://reviews.apache.org/r/61361/diff/2-3/ Testing ------- Thanks, Andrew Schwartzmeyer --===============8661924291148383599==--