From reviews-return-64398-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 4 16:40:41 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E3B9B197D4 for ; Fri, 4 Aug 2017 16:40:41 +0000 (UTC) Received: (qmail 65655 invoked by uid 500); 4 Aug 2017 16:40:41 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 65619 invoked by uid 500); 4 Aug 2017 16:40:41 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 65608 invoked by uid 99); 4 Aug 2017 16:40:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 16:40:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1F3C61A0A43; Fri, 4 Aug 2017 16:40:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id QewOjWjtHLm4; Fri, 4 Aug 2017 16:40:39 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 13E335F5B4; Fri, 4 Aug 2017 16:40:39 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 673EEE00A3; Fri, 4 Aug 2017 16:40:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 548E0C402BD; Fri, 4 Aug 2017 16:40:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3330996433616404868==" MIME-Version: 1.0 Subject: Re: Review Request 60439: Added scripts to automate website publishing. From: Benjamin Bannier To: Benjamin Bannier , haosdent huang , Benjamin Mahler Cc: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Vinod Kone , mesos Date: Fri, 04 Aug 2017 16:40:38 -0000 Message-ID: <20170804164038.17965.4817@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60439/ X-Sender: Benjamin Bannier References: <20170802085920.16836.87048@reviews-vm2.apache.org> In-Reply-To: <20170802085920.16836.87048@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: support/mesos-website/Dockerfile X-ReviewBoard-Diff-For: support/mesos-website.sh X-ReviewBoard-Diff-For: support/mesos-website/build.sh X-ReviewBoard-Diff-For: support/mesos-website/entrypoint.sh X-ReviewBoard-Diff-For: support/jenkins/websitebot.sh Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============3330996433616404868== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 2, 2017, 10:59 a.m., Benjamin Bannier wrote: > > support/mesos-website/entrypoint.sh > > Lines 23 (patched) > > > > > > Do you still recall why this was needed? It would be great to add e.g., a JIRA or a small reproducer to eval in the future whether this is still needed. > > Vinod Kone wrote: > Filed MESOS-7859 Thanks. Let's maybe add some more information how to reproduce that issue to the ticket; this e.g., works outside of the Docker container on macos. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review181951 ----------------------------------------------------------- On Aug. 4, 2017, 8:36 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60439/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2017, 8:36 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and haosdent huang. > > > Bugs: MESOS-7625 > https://issues.apache.org/jira/browse/MESOS-7625 > > > Repository: mesos > > > Description > ------- > > These scripts are expected to be run by ASF CI on any commit to > the mesos repo. The directory layout is similar to tidybot CI job. > > > Diffs > ----- > > support/jenkins/websitebot.sh PRE-CREATION > support/mesos-website.sh PRE-CREATION > support/mesos-website/Dockerfile PRE-CREATION > support/mesos-website/build.sh PRE-CREATION > support/mesos-website/entrypoint.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/60439/diff/3/ > > > Testing > ------- > > Tested by running a CI job pointing to a branch containing this patch. > > > Thanks, > > Vinod Kone > > --===============3330996433616404868==--