From reviews-return-64280-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 2 00:59:39 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B32B1ADF7 for ; Wed, 2 Aug 2017 00:59:39 +0000 (UTC) Received: (qmail 88013 invoked by uid 500); 2 Aug 2017 00:59:39 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 87977 invoked by uid 500); 2 Aug 2017 00:59:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87965 invoked by uid 99); 2 Aug 2017 00:59:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Aug 2017 00:59:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AF79DC004A; Wed, 2 Aug 2017 00:59:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6R4Zp9L_2AHJ; Wed, 2 Aug 2017 00:59:37 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B3ABD5F30C; Wed, 2 Aug 2017 00:59:37 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5D866E00A3; Wed, 2 Aug 2017 00:59:37 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4CA4EC400DA; Wed, 2 Aug 2017 00:59:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4503881184456330856==" MIME-Version: 1.0 Subject: Review Request 61365: Added `get_byproducts()` function to fix Ninja generator. From: Andrew Schwartzmeyer To: Andrew Schwartzmeyer , mesos Date: Wed, 02 Aug 2017 00:59:37 -0000 Message-ID: <20170802005937.55935.78600@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61365/ X-Sender: Andrew Schwartzmeyer Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============4503881184456330856== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61365/ ----------------------------------------------------------- Review request for mesos. Repository: mesos Description ------- CMake also supports Ninja as a generator, but Ninja requires that each use of `ExternalProject_Add` specifies its `BUILD_BYPRODUCTS`. Interestingly, it doesn't care about interface libraries, and furthermore, it can't derive the dependency from other information (despite it being available). Diffs ----- 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 Diff: https://reviews.apache.org/r/61365/diff/1/ Testing ------- Thanks, Andrew Schwartzmeyer --===============4503881184456330856==--