-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/
-----------------------------------------------------------
(Updated Aug. 28, 2017, 1:46 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Added manual testing.
Bugs: MESOS-7922
https://issues.apache.org/jira/browse/MESOS-7922
Repository: mesos
Description
-------
For re-registration, 1.4 agents used to send the resources in tasks
and executors to the master in the "post-reservation-refinement" format,
which is incompatible for pre-1.4 masters. This patch changes the agent
such that it always downgrades the resources to
the "pre-reservation-refinement" format, and the master unconditionally
upgrades the resources to "post-reservation-refinement" format.
Diffs
-----
src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9
src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176
Diff: https://reviews.apache.org/r/61952/diff/2/
Testing (updated)
-------
- Started 1.3.1 master, agent.
- Ran a persistent volume framework with the task commands changed to have `sleep 1000000`.
- Upgraded the agent from 1.3.1 to `master`.
- Observed the following message:
> W0828 12:48:22.066509 40596 master.cpp:5702] Dropping re-registration of agent
at slave(1)@10.0.49.2:5051 because it sent an invalid re-registration: Task uses
invalid resources: Invalid DiskInfo: Persistent volumes cannot be created from
unreserved resources
---
- Started 1.3.1 master, agent.
- Ran a persistent volume framework with the task commands changed to have `sleep 1000000`.
- Upgraded the agent from 1.3.1 to `master` + this patch.
- The agent was able to register successfully.
Thanks,
Michael Park
|