mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 61947: Implemented handling of resource provider offer operations.
Date Mon, 28 Aug 2017 18:30:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/#review183967
-----------------------------------------------------------



Bad patch!

Reviews applied: [61947, 61946, 61810, 58021, 58047, 58048, 57999, 57998, 57997, 57911]

Failed command: python support/apply-reviews.py -n -r 58048

Error:
2017-08-28 18:30:30 URL:https://reviews.apache.org/r/58048/diff/raw/ [11585/11585] -> "58048.patch"
[1]
error: patch failed: src/tests/mesos.hpp:875
error: src/tests/mesos.hpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19101/console

- Mesos Reviewbot


On Aug. 28, 2017, 8:30 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61947/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 8:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While the resource provider manager is responsible to apply offer
> operations by sending events to the respective resource providers,
> the master takes care of accepting these operations. Hence, for local
> resource providers the master sends an `ApplyResourceOperationMessage`
> to the agent where the resource provider is running on. The agent
> then relays the operation contained in the message to the resource
> provider manager.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9 
>   src/messages/messages.proto dc4e19c08d671743f08223dcdf1dbc336b3940bd 
>   src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094 
>   src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176 
>   src/tests/resource_provider_manager_tests.cpp 83a1340fa16b19e3297a8c0ca413afc312de00ec

> 
> 
> Diff: https://reviews.apache.org/r/61947/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message