mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58048: Added id to Resource.DiskInfo.
Date Mon, 28 Aug 2017 18:24:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review183960
-----------------------------------------------------------




src/common/resources.cpp
Line 187 (original), 187 (patched)
<https://reviews.apache.org/r/58048/#comment260003>

    We also need to update `addable` and `subtractable` similar to what we did for persistent
volumes.
    
    Depending on the "disk" source type, the semantics is different:
    1. RAW w/ id:
       - Cannot be split into smaller pieces
       - Cannot be merged even if they are equal
    2. RAW w/o id:
       - Can be split into smaller pieces
       - Can be merged if RAW parts equal
    3. PATH w/ id:
       - Can be split into smaller pieces
       - Can be merged if PATH parts equal
    4. PATH w/o id:
       - Same as PATH w/ id
    5. MOUNT w/ id:
       - Cannot be split into smaller pieces
       - Cannot be merged even if they are equal
    6. MOUNT w/o id:
       - Same as MOUNT w/ id


- Jie Yu


On May 19, 2017, 9:16 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
> 
> (Updated May 19, 2017, 9:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
>     https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154 
>   include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3 
>   src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c 
>   src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4 
>   src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3 
>   src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/4/
> 
> 
> Testing
> -------
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message