mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 61892: Propagate the error from os::rmdir.
Date Thu, 24 Aug 2017 19:34:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61892/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jiang Yan Xu.


Repository: mesos


Description
-------

Even when os::rmdir() is given the continueOnError flag, it should still
propagate a failure if it gets one. If we don't do this, the caller has
no way to detect and handle it.


Diffs
-----

  3rdparty/stout/include/stout/os/posix/rmdir.hpp 2427bd295f27a1b6b6bcf31b54f445184cdc7e89



Diff: https://reviews.apache.org/r/61892/diff/1/


Testing
-------

make check && sudo make check (Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message