mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 61869: Adjusted the ContianerLaunchInfo.command merge logic.
Date Wed, 23 Aug 2017 23:25:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61869/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and James Peach.


Bugs: MESOS-7909
    https://issues.apache.org/jira/browse/MESOS-7909


Repository: mesos


Description
-------

This patches addressed MESOS-7909 by eliminating the ordering
dependency between the `linux/capabilities` isolator and the
`docker/runtime` or `appc/runtime` isolator.

Now, for command tasks, we always merge with the command executor
command in MesosContainerizer. Previously, this is done in the
`docker/runtime` or `appc/runtime` isolator, which introduced this
unintentional dependency on the isolator ordering.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 5805dfb4fb6e755e4c23851b0a6b504f2a8b3396

  src/slave/containerizer/mesos/isolators/appc/runtime.cpp f76b22b26e371ec5ed5d81e86a78007224cc260e

  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 2a6e0b179394e0485d2495ceb4bbbcb184af08fe



Diff: https://reviews.apache.org/r/61869/diff/1/


Testing
-------

sudo make check

Also, verified with the previously failed ping tests.


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message