-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61575/#review183452
-----------------------------------------------------------
src/tests/default_executor_tests.cpp
Lines 719-720 (patched)
<https://reviews.apache.org/r/61575/#comment259455>
Can we at least test that a `TASK_KILLING` update is sent?
src/tests/kill_policy_test_helper.cpp
Lines 61-64 (original), 62-68 (patched)
<https://reviews.apache.org/r/61575/#comment259456>
Good idea checkpointing the ready state! Can we also checkpoint when we get `SIGTERM`
and `SIGKILL`? Or this is tricky due to async signal safety?
- Alexander Rukletsov
On Aug. 21, 2017, 9:26 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61575/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 9:26 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test uses the kill policy helper and blocks the SIGTERM signal.
>
> Review: https://reviews.apache.org/r/61575
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1
> src/tests/kill_policy_test_helper.hpp 29651102ec46b477e6e797c6e6bdef5b10afa665
> src/tests/kill_policy_test_helper.cpp a1880595ff015475f1ba49437d49f7397da19422
>
>
> Diff: https://reviews.apache.org/r/61575/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
|