mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 61538: Used common port range interval code in the port_mapping isolator.
Date Tue, 22 Aug 2017 03:45:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61538/#review183439
-----------------------------------------------------------



Can you explain a bit more why this change?

- Jie Yu


On Aug. 9, 2017, 8:18 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61538/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2017, 8:18 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Switched the port_mapping isolator over to start using the
> common values code to parse ranges into an IntervalSet. Since
> that is generic code, we now deal with ports as uint64_t rather
> than uint16_t.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 6ff3820de6af544c6ec92b0e76fd934715b87a96

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 57d4ccd515b538eece94a228916ec764c83473be

> 
> 
> Diff: https://reviews.apache.org/r/61538/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message