mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61309: Imported ZooKeeper library.
Date Thu, 17 Aug 2017 20:07:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61309/#review183151
-----------------------------------------------------------


Ship it!




Hmm... I will not squash this one into the other library import reviews (more functional differences
in this review compared to the other ones).

- Joseph Wu


On Aug. 8, 2017, 5:52 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61309/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2017, 5:52 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit imports the ZooKeeper C Client as a library, and removes the
> discrepancy between Linux and Windows. Both configurations now use
> ZooKeeper 3.4.8, with an updated patch to both build with CMake.
> 
> Review: https://reviews.apache.org/r/61309
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake fa1202a5a6a7d37d94b52e2142528febd1b23a10

>   3rdparty/cmake/Versions.cmake 9586296420d76bd4493034fd710209008ee03595 
> 
> 
> Diff: https://reviews.apache.org/r/61309/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message