mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61302: Added CMake function `make_include()` to work around bug.
Date Thu, 17 Aug 2017 19:25:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61302/#review183148
-----------------------------------------------------------


Ship it!




LGTM.  I'm going to expand on the commit description a little and rearrange the review so
this comes before the two reviews mentioned below.


3rdparty/CMakeLists.txt
Lines 241 (patched)
<https://reviews.apache.org/r/61302/#comment259177>

    I'm going to squash this line into https://reviews.apache.org/r/61291/



3rdparty/CMakeLists.txt
Lines 427 (patched)
<https://reviews.apache.org/r/61302/#comment259178>

    I'm going to squash this line into https://reviews.apache.org/r/61294/


- Joseph Wu


On Aug. 1, 2017, 5:55 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61302/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 5:55 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake function `make_include()` to work around bug.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 
> 
> 
> Diff: https://reviews.apache.org/r/61302/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message