mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61294: Imported `protobuf` library.
Date Thu, 17 Aug 2017 04:04:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61294/#review183098
-----------------------------------------------------------


Ship it!




Hm... I might squash all the reviews that change libraries to being imported (into https://reviews.apache.org/r/61291/
).  I'll come to a decision once I've gotten through all of said reviews.

Anyway, LGTM.  But needs some extra whitespace.  And some of the style isn't consistent (I'll
fixup).

- Joseph Wu


On Aug. 1, 2017, 5:54 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61294/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 5:54 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Imported `protobuf` library.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 
> 
> 
> Diff: https://reviews.apache.org/r/61294/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message