-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61602/#review183096
-----------------------------------------------------------
Bad patch!
Reviews applied: [61602]
Failed command: python support/apply-reviews.py -n -r 61602
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 417, in <module>
main()
File "support/apply-reviews.py", line 412, in main
reviewboard(options)
File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 160, in apply_review
commit_patch(options)
File "support/apply-reviews.py", line 261, in commit_patch
message.write(data['message'])
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 295: ordinal
not in range(128)
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/240/console
- Mesos Reviewbot Windows
On Aug. 16, 2017, 8:33 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61602/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 8:33 p.m.)
>
>
> Review request for mesos, Jie Yu, Kevin Klues, and Qian Zhang.
>
>
> Bugs: MESOS-7652
> https://issues.apache.org/jira/browse/MESOS-7652
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some docker image may have 'WORKDIR' set in its manifest but that
> 'WORKDIR' does not exist in the image rootfs (e.g., the workdir
> is removed in the following dockerfile).
>
> From the reference of dockerfile, "If the WORKDIR doesn’t exist,
> it will be created even if it’s not used in any subsequent
> Dockerfile instruction". So we should create the working directory
> if it does not exist in the image's rootfs.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp 8e662931697a2f20e0ac1e80a2911b96f646b5af
>
>
> Diff: https://reviews.apache.org/r/61602/diff/2/
>
>
> Testing
> -------
>
> make
>
> Manually tested using 'quay.io/spinnaker/front50:master' docker image.
>
>
> Thanks,
>
> Gilbert Song
>
>
|