-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61693/#review183092
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/composing.cpp
Lines 654-655 (patched)
<https://reviews.apache.org/r/61693/#comment259097>
Could we add a `TODO` here later?
TODO: the `destroy` callback would result in extra unnecessary containerizer->destroy()
call, which can be improved.
- Gilbert Song
On Aug. 16, 2017, 10:27 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61693/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 10:27 a.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The composing containerizer relies on users invoking `destroy()`
> for removing the container from the list of active containers.
> However, when using `kill()` the relevant containerizer just
> reaps the container without notifying the composing containerizer
> i.e., there is no `destroy()` invocation from the user. This change
> chains on the `wait()` future to invoke `destroy()` that
> eventually does the cleanup.
>
>
> Diffs
> -----
>
> src/slave/containerizer/composing.cpp f1a9c3d08b408aa61198f4042b9274df88b789ea
>
>
> Diff: https://reviews.apache.org/r/61693/diff/1/
>
>
> Testing
> -------
>
> sudo make check (tests pass)
>
>
> Thanks,
>
> Anand Mazumdar
>
>
|