mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60620: Modify os::write to write binary files on Windows.
Date Wed, 16 Aug 2017 12:19:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review180778
-----------------------------------------------------------


Ship it!




I'll fix this up before committing the chain.


3rdparty/stout/include/stout/os/write.hpp
Lines 70 (patched)
<https://reviews.apache.org/r/60620/#comment256006>

    Should be an `#ifdef`.



3rdparty/stout/include/stout/os/write.hpp
Lines 71 (patched)
<https://reviews.apache.org/r/60620/#comment256008>

    I'm going to drop a `NOTE:` comment here to explain the extra option.


- Joseph Wu


On July 5, 2017, 10:43 a.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modify os::write to write binary files on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/write.hpp beb5bd83b52565a75e34d32b5bb17951bc799578

> 
> 
> Diff: https://reviews.apache.org/r/60620/diff/2/
> 
> 
> Testing
> -------
> 
> Built successfully on both Linux (with autotools and cmake) and Windows (with cmake).
> 
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message