mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 61408: Added test cases for V1 teardown Call.
Date Tue, 15 Aug 2017 16:43:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review182954
-----------------------------------------------------------




src/tests/api_tests.cpp
Lines 2903-2904 (original), 2903-2905 (patched)
<https://reviews.apache.org/r/61408/#comment258921>

    Need one more newline here.



src/tests/api_tests.cpp
Lines 2987 (patched)
<https://reviews.apache.org/r/61408/#comment258924>

    s/of 'GET_FRAMEWORKS'/to the 'GET_FRAMEWORKS'/



src/tests/api_tests.cpp
Lines 2992 (patched)
<https://reviews.apache.org/r/61408/#comment258923>

    Since you do this at the beginning of the test, you don't need to do it here or anywhere
below.



src/tests/api_tests.cpp
Lines 3019-3023 (patched)
<https://reviews.apache.org/r/61408/#comment258922>

    Not indented far enough, here and below.



src/tests/api_tests.cpp
Lines 3052-3053 (patched)
<https://reviews.apache.org/r/61408/#comment258925>

    Could you add a comment here saying that the successful teardown call is being submitted?
I think it would improve readability a little.


- Greg Mann


On Aug. 15, 2017, 12:07 a.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 12:07 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-6846
>     https://issues.apache.org/jira/browse/MESOS-6846
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for teardown operation in V1 operator API.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9 
> 
> 
> Diff: https://reviews.apache.org/r/61408/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message