-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61493/#review182916
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/default_executor_tests.cpp
Line 1375 (original), 1375 (patched)
<https://reviews.apache.org/r/61493/#comment258856>
this test is linux specific, need `#ifdef __linux__`.
src/tests/default_executor_tests.cpp
Lines 1378 (patched)
<https://reviews.apache.org/r/61493/#comment258857>
should be a `ROOT` test.
src/tests/default_executor_tests.cpp
Lines 1383-1384 (patched)
<https://reviews.apache.org/r/61493/#comment258858>
`namespces/pid` isolator is not specified! all containers are sharing the agent's pid
ns by default.
src/tests/default_executor_tests.cpp
Lines 1414-1419 (patched)
<https://reviews.apache.org/r/61493/#comment258859>
not yours. this is a tech debt in this file. let's use `v1::scheduler::SendSubscribe()`.
src/tests/default_executor_tests.cpp
Lines 1427-1431 (patched)
<https://reviews.apache.org/r/61493/#comment258860>
use `v1::createExecutorInfo()`
src/tests/default_executor_tests.cpp
Lines 1463-1466 (patched)
<https://reviews.apache.org/r/61493/#comment258861>
oneline instead.
src/tests/default_executor_tests.cpp
Lines 1498-1501 (patched)
<https://reviews.apache.org/r/61493/#comment258862>
ditto.
src/tests/default_executor_tests.cpp
Lines 1510-1514 (patched)
<https://reviews.apache.org/r/61493/#comment258863>
save as `executorSandbox`.
- Gilbert Song
On Aug. 13, 2017, 7:06 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61493/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2017, 7:06 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod
Kone.
>
>
> Bugs: MESOS-7853
> https://issues.apache.org/jira/browse/MESOS-7853
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 3ac9f292f928aa67ee380a63233832365daa2cc2
>
>
> Diff: https://reviews.apache.org/r/61493/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
|