mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 61291: Imported `glog` library.
Date Fri, 11 Aug 2017 23:20:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61291/
-----------------------------------------------------------

(Updated Aug. 11, 2017, 4:20 p.m.)


Review request for mesos.


Changes
-------

Disallow linking to static library. Also brought over `GTEST_CONFIG=no` from Autotools.

Note that when we update Glog, and build with CMake, we'll be able to link to shared or static
as needed.


Repository: mesos


Description
-------

Review: https://reviews.apache.org/r/61291


Diffs (updated)
-----

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 


Diff: https://reviews.apache.org/r/61291/diff/3/

Changes: https://reviews.apache.org/r/61291/diff/2-3/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message