mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60525: Fixed the default filter used by the allocator.
Date Fri, 11 Aug 2017 19:47:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/#review182730
-----------------------------------------------------------




include/mesos/mesos.proto
Line 2257 (original), 2258-2262 (patched)
<https://reviews.apache.org/r/60525/#comment258724>

    Is there a suitable place in the documentation for us to mention this?
    
    Also, could you add an update for the changelog which calls out this change?



src/master/allocator/mesos/hierarchical.cpp
Line 1019 (original), 1019 (patched)
<https://reviews.apache.org/r/60525/#comment258727>

    s/timeout = timeout =/timeout =/



src/master/allocator/mesos/hierarchical.cpp
Lines 1022 (patched)
<https://reviews.apache.org/r/60525/#comment258728>

    s/filters.get()./filters->/
    
    here and elsewhere



src/master/allocator/mesos/hierarchical.cpp
Line 1021 (original), 1026 (patched)
<https://reviews.apache.org/r/60525/#comment258733>

    Can you just do
    
    ```
    timeout = Days(365);
    ```



src/master/allocator/mesos/hierarchical.cpp
Line 1170 (original), 1180 (patched)
<https://reviews.apache.org/r/60525/#comment258737>

    Ditto



src/master/allocator/mesos/hierarchical.cpp
Lines 1187 (patched)
<https://reviews.apache.org/r/60525/#comment258738>

    Ditto



src/master/allocator/mesos/hierarchical.cpp
Lines 1190 (patched)
<https://reviews.apache.org/r/60525/#comment258740>

    Could you make this language consistent here and below? This line uses "refused resources
offer filter", while the next one uses "refused resources filter".


- Greg Mann


On July 26, 2017, 11:30 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60525/
> -----------------------------------------------------------
> 
> (Updated July 26, 2017, 11:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod
Kone.
> 
> 
> Bugs: MESOS-7660
>     https://issues.apache.org/jira/browse/MESOS-7660
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a framework accepts/refuses an offer using a very long filter, the
> `HierarchicalAllocator` will use the default filter instead. Meaning
> that it will filter the resources for only 5 seconds. This can happen
> when a framework sets `Filter::refuse_seconds` to a number of seconds
> larger than what fits in `Duration`.
> 
> This patch makes the hierarchical allocator cap the filter duration to
> at most 365 days.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 
>   include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa 
>   src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035

> 
> 
> Diff: https://reviews.apache.org/r/60525/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message