mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.
Date Fri, 11 Aug 2017 09:02:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182670
-----------------------------------------------------------




support/apply-reviews.py
Lines 263-266 (original), 269-273 (patched)
<https://reviews.apache.org/r/61588/#comment258658>

    Not yours, but we don't necessarily need to disambiguate the keys we map the values onto,
e.g.,
    
        cmd = u'git commit --author \"{author}\" {amend} -aF \"{message}\" {verify}'.format(
            author=quote(data['author']),
            amend=amend,
            message=message_file,
            verify=verify)



support/apply-reviews.py
Line 364 (original), 371-373 (patched)
<https://reviews.apache.org/r/61588/#comment258659>

    Since this prevents running any (pre-)commit hooks, I wonder if we should give this a
more general name, e.g., simply expose `[-n|--no-verify]`.


- Benjamin Bannier


On Aug. 11, 2017, 1:41 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2017, 1:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7880
>     https://issues.apache.org/jira/browse/MESOS-7880
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a `--skip-style-check` option when applying reviews.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49 
> 
> 
> Diff: https://reviews.apache.org/r/61588/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message