mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Review Request 61564: Libprocess: Improved the readability of some assertions/expectations.
Date Thu, 10 Aug 2017 17:51:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61564/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.


Repository: mesos


Description
-------

Prefer checking whether a container is empty instead of checking its
size.


Diffs
-----

  3rdparty/libprocess/src/tests/decoder_tests.cpp 5742c83c632a2f03b4935738c3e78f39edc33e6d

  3rdparty/libprocess/src/tests/subprocess_tests.cpp d71fa4b9619a5fb5b8b8cae3310c36aaefc878ae



Diff: https://reviews.apache.org/r/61564/diff/1/


Testing
-------

The libprocess tests still pass.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message