mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <ben...@yandex-team.ru>
Subject Re: Review Request 61495: Add documentation for possible task reasons.
Date Thu, 10 Aug 2017 10:45:11 GMT


> On Aug. 10, 2017, 1:56 a.m., Till Toenshoff wrote:
> > docs/task-reasons.md
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/61495/diff/2/?file=1794141#file1794141line180>
> >
> >     Can we avoid HTML code here? We typically used HTML for getting tables properly
formatted as the apache site rendering otherwise caused issues in the resulting HTML code.
> >     
> >     If not done already, I would suggest you to play with the site renderer a bit
to see if the results are actually what you are hoping for.
> 
> Till Toenshoff wrote:
>     Just noticed you actually had that in the testing done section - sorry for not seeing
that earlier.

I had a look through the RDiscount docs (the markdown rendering engine we use) but I didn't
find any way to force a line break.
I switched to vertical bars here, but the same issue remains in the `**Note:**`-lines in some
of the descriptions, which are rendered as a single paragraph in HTML, but I don't know how
to fix this.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61495/#review182549
-----------------------------------------------------------


On Aug. 10, 2017, 10:43 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61495/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-5078
>     https://issues.apache.org/jira/browse/MESOS-5078
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add documentation for possible task reasons.
> 
> 
> Diffs
> -----
> 
>   docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca 
>   docs/task-state-reasons.md PRE-CREATION 
>   include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 
>   include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa 
>   src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 
> 
> 
> Diff: https://reviews.apache.org/r/61495/diff/3/
> 
> 
> Testing
> -------
> 
> Built website with site/build.sh and verified it renders ok.
> 
> HTML preview: http://htmlpreview.github.io/?https://github.com/lava/mesos/blob/bennoe/task-reasons/site/publish/documentation/latest/task-reasons/index.html
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message