mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 61515: Updated `CompilationConfigure.cmake` for imported libraries.
Date Thu, 10 Aug 2017 02:53:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61515/
-----------------------------------------------------------

(Updated Aug. 9, 2017, 7:53 p.m.)


Review request for mesos and Joseph Wu.


Changes
-------

Nothing else is referred to here with the "lib" prefix, so I removed it from libapr.


Repository: mesos


Description (updated)
-------

Windows and Linux have converged on several libraries (ZooKeeper,
Protobuf, and libevent) such that the same bundled version is used, so
the warning message was updated.

Third-party specific compilation flags were moved to the import of each
library, so this configuration no longer needs to include it.

The minimum CMake version was updated and usupports `string(TIMESTAMP)`,
deprecating the `date` work-around.


Diffs (updated)
-----

  cmake/CompilationConfigure.cmake 2109697e02e58c673948f2ae67ef8255d16aa736 


Diff: https://reviews.apache.org/r/61515/diff/2/

Changes: https://reviews.apache.org/r/61515/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message