mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.
Date Wed, 09 Aug 2017 00:47:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61434/#review182456
-----------------------------------------------------------




docs/health-checks.md
Lines 54-55 (original), 59-60 (patched)
<https://reviews.apache.org/r/61434/#comment258355>

    I'd revert part of the changes: 
    
    `s/if those are failing health checks/if the health checks fail/`



docs/health-checks.md
Lines 87 (patched)
<https://reviews.apache.org/r/61434/#comment258356>

    s/except docker executor/except the Docker executor/



docs/health-checks.md
Lines 112 (patched)
<https://reviews.apache.org/r/61434/#comment258357>

    s/unhealthy task/an unhealthy task/



docs/health-checks.md
Lines 114 (patched)
<https://reviews.apache.org/r/61434/#comment258358>

    s/1+2+3: run the check/1+2+3: they run the check/



docs/health-checks.md
Lines 136 (patched)
<https://reviews.apache.org/r/61434/#comment258359>

    Actually... only one status update is sent after a success, but failures are NOT deduplicated,
see:
    
    https://github.com/apache/mesos/blob/86e635b9f11e441bce3901a941c2d52b20518dbb/src/tests/health_check_tests.cpp#L990-L1076



docs/health-checks.md
Lines 160 (patched)
<https://reviews.apache.org/r/61434/#comment258361>

    s/3rdparty/third party/



docs/health-checks.md
Lines 168-169 (patched)
<https://reviews.apache.org/r/61434/#comment258363>

    s/check has not run yet, check has timed out/a has not run yet, or a check has timed out/



docs/health-checks.md
Lines 180 (patched)
<https://reviews.apache.org/r/61434/#comment258364>

    s/`CheckInfo.Command` message/the `CheckInfo.Command` message/



docs/health-checks.md
Lines 194 (patched)
<https://reviews.apache.org/r/61434/#comment258365>

    I'd add here (and in the following snippets):
    
    ```
    TaskInfo task = [...];
    
    ```



docs/health-checks.md
Lines 266 (patched)
<https://reviews.apache.org/r/61434/#comment258366>

    Don't the executors send an empty check status in this case? See `CommandExecutorCheckTest.CommandCheckTimeout`.



docs/health-checks.md
Line 273 (original), 501 (patched)
<https://reviews.apache.org/r/61434/#comment258367>

    s/docker/Docker/


- Gastón Kleiman


On Aug. 4, 2017, 6:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61434/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7349
>     https://issues.apache.org/jira/browse/MESOS-7349
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md d0749347d1f9398004e56b03503d655b5fba75f4 
> 
> 
> Diff: https://reviews.apache.org/r/61434/diff/1/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded
> 
> Additionally rendered in MacDown.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message