mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 61182: Sent a resource provider message when providers subscribe.
Date Tue, 08 Aug 2017 13:53:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/#review182387
-----------------------------------------------------------



Looks great, only nitpicking here. Please rebase, `resource_provider::Driver` has been changed
to allow reconnections using an `EndpointDetector`.


src/tests/resource_provider_manager_tests.cpp
Lines 383 (patched)
<https://reviews.apache.org/r/61182/#comment258276>

    Nit: Use `v1::ResourceProviderInfo` instead of `mesos::v1::ResourceProviderInfo` to be
consistent with the use of the `v1` namespace in this test.



src/tests/resource_provider_manager_tests.cpp
Lines 394 (patched)
<https://reviews.apache.org/r/61182/#comment258277>

    See nit above.


- Jan Schlicht


On Aug. 1, 2017, 7:42 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61182/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 7:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7837
>     https://issues.apache.org/jira/browse/MESOS-7837
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to inform users of resource provider managers that the
> managed resources have changed, we add a new 'ResourceProviderMessage'
> type for communicating changes to the managed total resources.
> 
> We add code to trigger sending of that message when a resource
> provider subscribes with the manager.
> 
> In the future this message could also be used to communicate changes
> to an already subscribed resource provider's total resources.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462 
>   src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04 
>   src/tests/resource_provider_manager_tests.cpp 85906ea5e1bb3516ef264de22913ce0a3c9c58c5

> 
> 
> Diff: https://reviews.apache.org/r/61182/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message