mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <>
Subject Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest`.
Date Tue, 08 Aug 2017 09:43:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 8, 2017, 5:43 p.m.)

Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.


Addressed comments.

Summary (updated)

Fixed a bug in the test `NamespacesIsolatorTest`.

Repository: mesos

Description (updated)

In this test, we used the command `stat -c %i` to get the current
process's pid/ipc namespace inode, that is not correct since
`/proc/self/ns/pid` and `/proc/self/ns/ipc` are symbol links, we
should get the inode that the link references rather than the link
itself. So we need to add a `-L` option in the `stat` command.

Diffs (updated)

  src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230 





Qian Zhang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message