mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61098: Added unit tests for gRPC support in libprocess.
Date Tue, 08 Aug 2017 00:36:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/
-----------------------------------------------------------

(Updated Aug. 8, 2017, 12:36 a.m.)


Review request for mesos, Benjamin Mahler, Jie Yu, Joseph Wu, and Zhitao Li.


Changes
-------

Addressed Jie's comments.


Bugs: MESOS-7810
    https://issues.apache.org/jira/browse/MESOS-7810


Repository: mesos


Description
-------

We tested the following 6 scenarios when making gRPC calls:

1. The server responds with an OK.
2. The server responds with a failure.
3. The client discards the call before the server starts.
4. The client discards the call when the server is processing it.
5. The client makes mulitple concurrent calls.
6. The client shuts down during a call.
7. The server is unreachable.
8. The server dose not respond in time.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION 


Diff: https://reviews.apache.org/r/61098/diff/6/

Changes: https://reviews.apache.org/r/61098/diff/5-6/


Testing
-------

N/A


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message