mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61284: Made `libprocess` use default linking.
Date Mon, 07 Aug 2017 23:56:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61284/#review182342
-----------------------------------------------------------


Ship it!




[Tentative "Ship It!" as I review this entire chain.]

Because I like to add context to commit messages, I'm going to extend your commit message
to mention why these things are redundant:
(: the `BUILD_SHARED_LIBS` and `CMAKE_POSITION_INDEPENDENT_CODE` global variables :)

- Joseph Wu


On Aug. 1, 2017, 5:52 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61284/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 5:52 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The static/shared specifier and the PIC property were redundant.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/CMakeLists.txt fbad7a0dd0347a308ba504ff7daeed187dd1f94d 
> 
> 
> Diff: https://reviews.apache.org/r/61284/diff/1/
> 
> 
> Testing
> -------
> 
> Actually, this whole file was rewritten later, with this change included. Could be squashed.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message