mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61474: Removed an unused function in src/linux/ns.hpp.
Date Mon, 07 Aug 2017 20:53:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61474/#review182324
-----------------------------------------------------------


Ship it!




Looks like the last reference to this function was removed as part of this cleanup: https://reviews.apache.org/r/51963/
(Want to mention that in your commit description?)

- Joseph Wu


On Aug. 7, 2017, 12:05 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61474/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2017, 12:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-7858
>     https://issues.apache.org/jira/browse/MESOS-7858
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed an unused function in src/linux/ns.hpp.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 941c7ee243e0e486ee263a9e6c4f6d0a7398427d 
>   src/tests/containerizer/ns_tests.cpp 0c748960488e1ef8356273a0f7ff6e0aaa21ad47 
> 
> 
> Diff: https://reviews.apache.org/r/61474/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message