mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 61455: Tweaked checker logs to avoid repeated information.
Date Mon, 07 Aug 2017 16:08:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61455/#review182282
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On Aug. 7, 2017, 10:47 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61455/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2017, 10:47 a.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Macro `WSTRINGIFY` already prints some test before printing the exit
> code of the command or termination signal. Hence adding "returned"
> word prior to invoking this macro is not necessary and might even be
> misleading.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.cpp d92588e9e7235cf403b9b18cd7cd58e652a9f2a2 
>   src/checks/health_checker.cpp 41fd94906407b59b1f27033324279d6a0ee2cf4b 
> 
> 
> Diff: https://reviews.apache.org/r/61455/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message