mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <>
Subject Re: Review Request 58898: Do not kill non partition aware tasks.
Date Sun, 06 Aug 2017 04:35:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 6, 2017, 4:35 a.m.)

Review request for mesos, Neil Conway and Jiang Yan Xu.

Summary (updated)

Do not kill non partition aware tasks.

Bugs: MESOS-7215

Repository: mesos

Description (updated)

Master will not kill the tasks for non-Partition aware frameworks
when an unreachable agent re-registers with the master.
Master used to send a ShutdownFrameworkMessages to the agent
to kill the tasks from non partition aware frameworks including the
ones that are still registered which was problematic because the offer
from this agent could still go to the same framework which could then
launch new tasks. The agent would then receive tasks of the same
framework and ignore them because it thinks the framework is shutting
down. The framework is not shutting down of course, so from the master
and the scheduler’s perspective the task is pending in STAGING forever
until the next agent reregistration, which could happen much later.
This commit fixes the problem by not shutting down the non-partition
aware frameworks on such an agent.

Diffs (updated)

  src/master/http.cpp 959091c8ec03b6ac7bcb5d21b04d2f7d5aff7d54 
  src/master/master.hpp b802fd153a10f6012cea381f153c28cc78cae995 
  src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 
  src/tests/partition_tests.cpp 62a84f797201ccd18b71490949e3130d2b9c3668 




make check


Megha Sharma

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message