mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 61270: Added container PID namespace control protobuf field in LinuxInfo.
Date Sat, 05 Aug 2017 00:47:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61270/#review182250
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 2741-2746 (patched)
<https://reviews.apache.org/r/61270/#comment258147>

    I'd put something like this:
    
    ```
    If set, then the container will share the PID namespace with its parent. If the container
is a top-level container, then it will share the PID namespace with the agent. If it is a
nested container, it will shar the PID namespace with its parent container. This field will
be ignored if the `namespaces/pid` isolator is not enabled.
    ```


- Gastón Kleiman


On Aug. 3, 2017, 9:40 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61270/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 9:40 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gastón Kleiman, Jie Yu, Kevin Klues, Qian
Zhang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> User facing interface for container configurable PID namespace.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 
>   include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa 
> 
> 
> Diff: https://reviews.apache.org/r/61270/diff/3/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message