mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 61394: Made the capabilities isolator work with nested containers.
Date Fri, 04 Aug 2017 22:29:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61394/#review182242
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/linux_capabilities_isolator_tests.cpp
Lines 476 (patched)
<https://reviews.apache.org/r/61394/#comment258137>

    2 lines apart.


- Jie Yu


On Aug. 4, 2017, 9:57 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61394/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2017, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-7849
>     https://issues.apache.org/jira/browse/MESOS-7849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Make the capabilities isolator support nesting. Without this patch
> capabilities sets for tasks launched by the DefaultExecutor are silently
> ignored.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/linux/capabilities.hpp c3afe2054bb206e9b2823c008435f78e70ce7d63

>   src/slave/containerizer/mesos/isolators/linux/capabilities.cpp f85a84d3871307bd1e9ebd45388ba680534acd89

>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 80508760f8d635b414651e521848315399918fbc

> 
> 
> Diff: https://reviews.apache.org/r/61394/diff/3/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh --gtest_filter="*LinuxCapabilitiesIsolatorTest*"`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message