mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61098: Added unit tests for gRPC support in libprocess.
Date Fri, 04 Aug 2017 16:01:34 GMT


> On Aug. 4, 2017, 3:53 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/tests/grpc_tests.cpp
> > Lines 95 (patched)
> > <https://reviews.apache.org/r/61098/diff/5/?file=1788537#file1788537line95>
> >
> >     Can we just make this test conditional compile in the makefile?

This fileis already conditional compiled. I put the condition here again to emphasize that
the tests use unix sockets for server addresses. Once we support windows in the future, we
might still want to test grpc, so how about using a fixed address, say `localhost:50051` for
addresses on Windows?


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/#review182212
-----------------------------------------------------------


On Aug. 3, 2017, 6:04 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61098/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 6:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, Joseph Wu, and Zhitao Li.
> 
> 
> Bugs: MESOS-7810
>     https://issues.apache.org/jira/browse/MESOS-7810
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We tested the following 6 scenarios when making gRPC calls:
> 
> 1. The server responds with an OK.
> 2. The server responds with a failure.
> 3. The client discards the call before the server starts.
> 4. The client discards the call when the server is processing it.
> 5. The client makes mulitple concurrent calls.
> 6. The client shuts down during a call.
> 7. The server is unreachable.
> 8. The server dose not respond in time.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61098/diff/5/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message