mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 61272: Added a MockResourceProvider.
Date Thu, 03 Aug 2017 10:00:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61272/#review182088
-----------------------------------------------------------




src/tests/mesos.hpp
Lines 2258-2259 (patched)
<https://reviews.apache.org/r/61272/#comment257954>

    This is not needed as these functions will be declared automatically.



src/tests/mesos.hpp
Lines 2291 (patched)
<https://reviews.apache.org/r/61272/#comment257955>

    We want to construct our actual base class object of type `Driver` here, e.g.,
    
        : Driver( ...



src/tests/mesos.hpp
Lines 2301 (patched)
<https://reviews.apache.org/r/61272/#comment257951>

    How about passing this as an argument instead? It semantically belongs to the remote description
we already pass (`url`, `contentType`).



src/tests/mesos.hpp
Lines 2308 (patched)
<https://reviews.apache.org/r/61272/#comment257953>

    It seems weird to `move` here. `std::queue::front` returns a reference, and we need to
make a copy anyway.


- Benjamin Bannier


On Aug. 2, 2017, 1:38 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61272/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 1:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7469
>     https://issues.apache.org/jira/browse/MESOS-7469
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a MockResourceProvider.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 6f06261d81870b923b7053daf8205327c4ac6a45 
> 
> 
> Diff: https://reviews.apache.org/r/61272/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message