mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61098: Added unit tests for gRPC support in libprocess.
Date Wed, 02 Aug 2017 20:17:05 GMT


> On Aug. 2, 2017, 10:01 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/61098/diff/4/?file=1784966#file1784966line1>
> >
> >     I believe adding generated protobuf files to the repository is not a good idea
(in addition to being highly redundant it also might not work if a user uses e.g., an unbundled
protobuf-2.6.1). Have a look at e6ec4e8362552cbaf74bf3e844e7ac4b15f9aafd for an example of
how to generate test proto files during the build instead of checking them in.

Yeah I just noticed that the protobuf test in stout has been changed to avoid this. Let me
figure out a way to auto-gen the grpc code. Thanks.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61098/#review181957
-----------------------------------------------------------


On July 28, 2017, 12:49 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61098/
> -----------------------------------------------------------
> 
> (Updated July 28, 2017, 12:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-7810
>     https://issues.apache.org/jira/browse/MESOS-7810
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We tested the following 6 scenarios when making gRPC calls:
> 
> 1. The server responds with an OK.
> 2. The server responds with a failure.
> 3. The client discards the calls.
> 4. The client makes mulitple outstanding calls.
> 5. The client shuts down during a call.
> 6. The server is unreachable.
> 7. The server dose not respond in time.
> 
> `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and
> `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc
> 1.4.2 through the following command, assuming the current working
> directory is `3rdparty/libprocess/src/tests`:
> $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \
>   --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \
>   grpc_tests.proto
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION 
>   3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION 
>   3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION 
>   3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION 
>   3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61098/diff/4/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message