mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 61385: Fixed linking to OpenSSL libraries.
Date Wed, 02 Aug 2017 20:14:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61385/
-----------------------------------------------------------

(Updated Aug. 2, 2017, 1:14 p.m.)


Review request for mesos, Benjamin Bannier and Joseph Wu.


Repository: mesos


Description
-------

The libraries have to be linked publicly for `libprocess-tests`. The
crypto library was missing. We need to pass along `OPENSSL_ROOT_DIR` if
set for systems like OS X.


Diffs
-----

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 
  3rdparty/libprocess/src/CMakeLists.txt fbad7a0dd0347a308ba504ff7daeed187dd1f94d 


Diff: https://reviews.apache.org/r/61385/diff/1/


Testing (updated)
-------

Configured with `-DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl`
on OS X.

Ran `libprocess-tests --gtest_filter="SSL*"`
```
[----------] Global test environment tear-down
[==========] 23 tests from 3 test cases ran. (10451 ms total)
[  PASSED  ] 23 tests.
```


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message