mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61097: Added gRPC support in libprocess.
Date Wed, 02 Aug 2017 19:19:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61097/
-----------------------------------------------------------

(Updated Aug. 2, 2017, 7:19 p.m.)


Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.


Changes
-------

Addressed Jie's comments.


Bugs: MESOS-7810
    https://issues.apache.org/jira/browse/MESOS-7810


Repository: mesos


Description
-------

A gRPC client can create a `process::grpc::client::Runtime` instance and
use its `call()` method to send an asynchronous gRPC call to `Channel`
(representing a connection to a gRPC server), and get a future waiting
for the response. The `Runtime` class maintains a `CompletionQueue` to
manage all pending asynchronous gRPC calls, and spawns a thread waiting
for any response from the `CompletionQueue`. All gRPC calls using the
same `Runtime` copy would share the same `CompletionQueue` and thread.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/grpc.hpp PRE-CREATION 
  3rdparty/libprocess/src/grpc.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/61097/diff/5/

Changes: https://reviews.apache.org/r/61097/diff/4-5/


Testing
-------

N/A


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message