mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 61245: Added a test `DefaultContainerDNSFlagTest.ValidateFlag`.
Date Wed, 02 Aug 2017 15:51:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61245/#review181997
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/tests/slave_tests.cpp
Lines 7942 (patched)
<https://reviews.apache.org/r/61245/#comment257812>

    We could do something like:
    ```
    string network_mode = (containerizer == "mesos" ? "CNI"  : "USER");
    
     defaultContainerDNSInfo =
          "--default_container_dns={"
          "  \"" + containerizer + "\": [\n"
          "    {\n"
          "      \"network_mode\": + network_mode+ ",\n"
          "      \"dns\": {\n"
          "        \"nameservers\": [ \"8.8.8.8\" ]\n"
          "      }\n"
          "    },\n"
          "    {\n"
          "      \"network_mode\": \"CNI\",\n"
          "      \"dns\": {\n"
          "        \"nameservers\": [ \"8.8.8.8\" ]\n"
          "      }\n"
          "    }\n"
          "  ]\n"
          "}";
    
    ```
    
    That way we wouldn't need the `else` ocondtitional below ?


- Avinash sridharan


On Aug. 2, 2017, 8:15 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61245/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 8:15 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
>     https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `DefaultContainerDNSFlagTest.ValidateFlag`.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp a8c3a7749472739c72de2deebe6220c724e635bb 
> 
> 
> Diff: https://reviews.apache.org/r/61245/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message